Skip to content

Conversation

theferrit32
Copy link
Contributor

Annotating v4 genomes now fails since the v4 genomes table uses ancestry population names from v4. This fixes that.

@klaricch klaricch self-requested a review March 28, 2024 15:18
@klaricch
Copy link
Contributor

can you clarify the issue? does it involve the change from oth -> remaining?
just switching to always use POPS v4 isn't suitable as currently written because it would drop 'ami' from genomes

@klaricch klaricch self-assigned this Mar 28, 2024
Copy link
Contributor

@klaricch klaricch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theferrit32
Copy link
Contributor Author

Yes @klaricch this was because some of the v3 genomes population labels are no longer in the v4 genomes so it was getting a KeyError. I guess this change is too imprecise though because it might miss some that are there. Do you have an idea of how to better keep the population labels we reference in sync with what's in the tables?

Should another set of labels be added? If v3 genomes and v4 genomes and v4 exomes don't all have the same ancestry groups then do we need 3 sets of keys instead of just the two v3 and v4 in hardcoded in there now? Or can we infer the groups from whatever's in the table?

@klaricch
Copy link
Contributor

I think the issue you were seeing should be resolved with this PR (#690), but if not, let me know

@klaricch klaricch closed this Apr 11, 2024
@theferrit32
Copy link
Contributor Author

Thank you @klaricch !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants